Override babelrc for the node related code #4451
Conversation
igor-dv
requested review from
alterx,
dangreenisrael,
danielduan,
Gongreg,
kazupon,
leonrodenburg,
naipath,
ndelangen,
rmevans9,
shilman,
thomasbertet and
tmeasday
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4451 +/- ##
==========================================
- Coverage 35.96% 35.94% -0.03%
==========================================
Files 555 555
Lines 6653 6658 +5
Branches 871 869 -2
==========================================
Hits 2393 2393
- Misses 3813 3820 +7
+ Partials 447 445 -2
Continue to review full report at Codecov.
|
|
You can use |
|
Oh, that's much better |
igor-dv
changed the title
| "./addons/storyshots", | ||
| "./addons/storysource/src/loader", | ||
| "./app/**/src/server/**" | ||
| ], |
There was a problem hiding this comment.
I think you can also add lib/cli here, and remove lib/cli/.babelrc
There was a problem hiding this comment.
Added codemod.
lib/cli seems not transpiled like other packages (there is no src dir in)
There was a problem hiding this comment.
Yeah, but the "scripts/compile-js" is not handling this I think... I mean, do you think I need to change this?
There was a problem hiding this comment.
I think there's nothing special about lib/cli package, so we can switch it from babel-register to transpiling
There was a problem hiding this comment.
Cool. Will wait for #4236 to be finished. Then will move it to src dir.
Issue: We may optimize the Node related code to be transpired for Node. That will reduce the package size a bit and will ease a debugging
What I did
I've added the Node specific.babelrcin a few placesOverridden the root babelrc for the Node related code