-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI add command #4236
CLI add command #4236
Conversation
It's fine |
Codecov Report
@@ Coverage Diff @@
## next #4236 +/- ##
==========================================
+ Coverage 35.05% 35.09% +0.04%
==========================================
Files 593 594 +1
Lines 7348 7408 +60
Branches 1000 1016 +16
==========================================
+ Hits 2576 2600 +24
- Misses 4259 4290 +31
- Partials 513 518 +5
Continue to review full report at Codecov.
|
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
Trying to pick things up again from where I left off 😄 @shilman @ndelangen could I get your thoughts/reviews on this PR? Maybe we can also talk on Discord about what we wanted to work on regarding the CLI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
@Keraito Can you resolve the conflicts? |
will do @shilman ! |
Should be good now @shilman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NICE!
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
Issue: More CLI enhancements.
What I did
Added an
add
command to the storybook CLI to add addons to the Storybook project.How does it work
storybook add <addon>
. This can be either an official storybook addon likeknobs
or a random npm package. It can also include a tag likeknobs@alpha
, as long as it works withyarn
ornpm
.yarn info @storybook/addons-<addon> version
(or npm equivalent).yarn info <addon> version
.isOfficialAddon = false
.isOfficialAddon = true
.isOfficialAddon
:yarn add -D <addon>
*.package.json
for installed Storybook packages.yarn add -D @storybook/addons-<addon>@<version>
.yarn add -D @storybook/addons-<addon>
..storybook/addons.js
and put a register statement after the last register occurrence.*Maybe adjusting the package.json and then running
yarn
/npm install
is a better long term solution?**Works under the assumption that the user has the same versions for every installed official Storybook package. My plan is to add some checks on this and warn the user about it in the future.
Please tell me what you guys think, both feature and implementation wise!