Skip preflight check when starting cra kitchen sink #4408
Conversation
chadfawcett
requested review from
Hypnosphi,
ndelangen and
usulpro
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4408 +/- ##
=======================================
Coverage 36.02% 36.02%
=======================================
Files 557 557
Lines 6643 6643
Branches 869 869
=======================================
Hits 2393 2393
Misses 3805 3805
Partials 445 445Continue to review full report at Codecov.
|
| @@ -6,7 +6,7 @@ | |||
| "build": "react-scripts build", | |||
| "build-storybook": "build-storybook -s public", | |||
| "eject": "react-scripts eject", | |||
| "start": "react-scripts start", | |||
| "start": "SKIP_PREFLIGHT_CHECK=true react-scripts start", | |||
There was a problem hiding this comment.
the error message recommends using .env file for that
There was a problem hiding this comment.
Sorry, you're right. I thought if it was in a .env file we'd have to source it resulting in the same amount of code. Turns out react-scripts will do that for us.
However, .env is in examples/cra-kitchen-sink/.gitignore so it can't be committed. What is the better solution here, leave things as they are, or remove .env from the git ignore?
There was a problem hiding this comment.
Yes, let's remove it from gitignore
|
We definitely should reflect it in docs |
Issue: Resolves #4376
What I did
Added a preflight check env variable before starting the cra kitchen sink app. This allows the app to start without complaining about slight version conflicts upstream.
How to test
cd examples/cra-kitchen-sink && yarn start