Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cra-kitchen-sink] fails to start with dependency version conflicts #4376

Closed
chadfawcett opened this issue Oct 12, 2018 · 5 comments
Closed
Labels
documentation maintenance User-facing maintenance tasks react

Comments

@chadfawcett
Copy link
Member

Bug or support request summary

When I navigate to examples/cra-kitchen-sink and run yarn start I expect the app to compile and start in the react-scripts dev server.

Instead, an error message appears:

There might be a problem with the project dependency tree.
It is likely not a bug in Create React App, but something you need to fix locally.

The react-scripts package provided by Create React App requires a dependency:

  "babel-eslint": "9.0.0"

Don't try to install it manually: your package manager does it automatically.
However, a different version of babel-eslint was detected higher up in the tree:

  /Users/chadfawcett/workspace/contributing/storybook/node_modules/babel-eslint (version: 10.0.1)

Manually installing incompatible versions is known to cause hard-to-debug issues.

If prefer to ignore this check, add SKIP_PREFLIGHT_CHECK=true to an .env file in your project.
That will permanently disable this message but you might encounter other issues.

To fix the dependency tree, try following the steps below in the exact order:

  1. Delete package-lock.json (not package.json!) and/or yarn.lock in your project folder.
  2. Delete node_modules in your project folder.
  3. Remove "babel-eslint" from dependencies and/or devDependencies in the package.json file in your project folder.
  4. Run npm install or yarn, depending on the package manager you use.

In most cases, this should be enough to fix the problem.
If this has not helped, there are a few other things you can try:

  5. If you used npm, install yarn (http://yarnpkg.com/) and repeat the above steps with it instead.
     This may help because npm has known issues with package hoisting which may get resolved in future versions.

  6. Check if /Users/chadfawcett/workspace/contributing/storybook/node_modules/babel-eslint is outside your project directory.
     For example, you might have accidentally installed something in your home folder.

  7. Try running npm ls babel-eslint in your project folder.
     This will tell you which other package (apart from the expected react-scripts) installed babel-eslint.

If nothing else helps, add SKIP_PREFLIGHT_CHECK=true to an .env file in your project.
That would permanently disable this preflight check in case you want to proceed anyway.

P.S. We know this message is long but please read the steps above :-) We hope you find them helpful!

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Steps to reproduce

yarn bootstrap --reset --core
cd examples/cra-kitchen-sink
yarn start

Please specify which version of Storybook and optionally any affected addons that you're running

> yarn list --pattern @storybook
yarn list v1.10.1
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
├─ @storybook/[email protected]
└─ @storybook/[email protected]

Affected platforms

@chadfawcett
Copy link
Member Author

SKIP_PREFLIGHT_CHECK=true yarn start allows for bypassing the pre check and everything seems to work, but I'm not sure that this is an appropriate enough solution to make a PR.

@Hypnosphi Hypnosphi added documentation maintenance User-facing maintenance tasks and removed bug labels Oct 13, 2018
@Hypnosphi
Copy link
Member

We definitely need babel-eslint up in the tree. Please open a PR with SKIP_PREFLIGHT_CHECK=true

@AtNovember
Copy link

SKIP_PREFLIGHT_CHECK=true yarn start

this aproach does`t work with react 16.7.0-alpha (i wanted to try their new functional stuffs)

@VladimirTambovtsev
Copy link

Adding SKIP_PREFLIGHT_CHECK=true to .env file doesn't help.

>>create-react-app --version
2.0.4

@chadfawcett
Copy link
Member Author

Are you attempting to run the cra-kitchen-sink or are you creating a new project from create-react-app?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation maintenance User-facing maintenance tasks react
Projects
None yet
Development

No branches or pull requests

5 participants