Fix linter warnings #4172
Merged
Fix linter warnings #4172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-dv
requested review from
dangreenisrael,
danielduan,
Hypnosphi,
ndelangen,
shilman,
stijnkoopal,
theinterned,
usulpro and
z4o4z
as code owners
|
If anyone wonders what this PR is doing - it's just about fixing linter's warnings |
Keraito
approved these changes
Sep 13, 2018
pksunkara
approved these changes
Sep 13, 2018
Hypnosphi
reviewed
Sep 13, 2018
| @@ -17,8 +17,8 @@ | |||
|
|
|||
| #### Other | |||
|
|
|||
| - [WIP] Refactor core and frameworks to work with presets [#4043](https://github.com/storybooks/storybook/pull/4043) | |||
| - [WIP] presets - merge default babel configs [#4107](https://github.com/storybooks/storybook/pull/4107) | |||
| - \[WIP\] Refactor core and frameworks to work with presets [#4043](https://github.com/storybooks/storybook/pull/4043) | |||
There was a problem hiding this comment.
We can't do it each time. I'd suggest just disabling linting for this file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Linter warnings fixes
What I did
I've fixed warnings of the linter.
How to test
Just look if linter has warnings 🤷♂️