Merge pull request #4172 from storybooks/fix-linter

Fix linter warnings

CHANGELOG.md

@@ -17,8 +17,8 @@
 
 #### Other
 
--   [WIP] Refactor core and frameworks to work with presets [#4043](https://github.com/storybooks/storybook/pull/4043)
--   [WIP] presets - merge default babel configs [#4107](https://github.com/storybooks/storybook/pull/4107)
+-   \[WIP\] Refactor core and frameworks to work with presets [#4043](https://github.com/storybooks/storybook/pull/4043)
+-   \[WIP\] presets - merge default babel configs [#4107](https://github.com/storybooks/storybook/pull/4107)
 
 # 4.0.0-alpha.20
 
@@ -95,7 +95,7 @@ Not published to NPM
 -   Temp revert the 36a2676 [#4062](https://github.com/storybooks/storybook/pull/4062)
 -   Remove deprecation of --db-path and --enable-db [#4030](https://github.com/storybooks/storybook/pull/4030)
 -   Remove git info extraction [#4031](https://github.com/storybooks/storybook/pull/4031)
--   Fixed homepage links [skip ci] [#4008](https://github.com/storybooks/storybook/pull/4008)
+-   Fixed homepage links \[skip ci\] [#4008](https://github.com/storybooks/storybook/pull/4008)
 -   CHANGE html-webpack-plugin for generate-page-plugin [#3919](https://github.com/storybooks/storybook/pull/3919)
 
 # 4.0.0-alpha.16
@@ -108,7 +108,7 @@ Not published to NPM
 
 #### Bug Fixes
 
--   [BUG FIX] Use fixed version of react-dev-utils [#3959](https://github.com/storybooks/storybook/pull/3959)
+-   \[BUG FIX\] Use fixed version of react-dev-utils [#3959](https://github.com/storybooks/storybook/pull/3959)
 -   Inline emotion css calls that require theme to avoid using state [#3950](https://github.com/storybooks/storybook/pull/3950)
 
 #### Dependency Upgrades
@@ -998,7 +998,7 @@ Read on for more improvements, fixes, 1In addition, there are hundreds of depend
 
 #### Bug Fixes
 
--   [Addon-storyshots] Remove default options on "goto" call [#3298](https://github.com/storybooks/storybook/pull/3298)
+-   \[Addon-storyshots\] Remove default options on "goto" call [#3298](https://github.com/storybooks/storybook/pull/3298)
 -   CLI: add error handling for latest_version helper [#3297](https://github.com/storybooks/storybook/pull/3297)
 -   Refactor CLI to use `npm` and `yarn` instead of third party packages [#3275](https://github.com/storybooks/storybook/pull/3275)
 -   Fix issue when extending webpack config [#3279](https://github.com/storybooks/storybook/pull/3279)
@@ -1058,7 +1058,7 @@ Read on for more improvements, fixes, 1In addition, there are hundreds of depend
 
 #### Bug Fixes
 
--   [Hotfix]  Use published webpack 4 compatible fork of react-dev-utils [#3312](https://github.com/storybooks/storybook/pull/3312)
+-  \[Hotfix\]  Use published webpack 4 compatible fork of react-dev-utils [#3312](https://github.com/storybooks/storybook/pull/3312)
 
 # 4.0.0-alpha.0
 
@@ -1085,7 +1085,7 @@ Read on for more improvements, fixes, 1In addition, there are hundreds of depend
 #### Bug Fixes
 
 -   Update react-native symlink resolving and add support for flow [#3306](https://github.com/storybooks/storybook/pull/3306)
--   [Addon-storyshots] Remove default options on "goto" call [#3298](https://github.com/storybooks/storybook/pull/3298)
+-   \[Addon-storyshots\] Remove default options on "goto" call [#3298](https://github.com/storybooks/storybook/pull/3298)
 -   Remove onDeviceUI animation to support Detox screenshots [#3272](https://github.com/storybooks/storybook/pull/3272)
 -   Angular: use resolveLoader from cliCommonConfig [#3251](https://github.com/storybooks/storybook/pull/3251)
 

MIGRATION.md

@@ -82,11 +82,11 @@ Storybook now uses webpack 4. If you have a [custom webpack config](https://stor
 
 Storybook now uses Babel 7. There's a couple of cases when it can break with your app:
 
-  * If you aren't using Babel yourself, and don't have .babelrc, install following dependencies:
-    ```
-    npm i -D @babel/core babel-loader@next
-    ```
-  * If you're using Babel 6, make sure that you have direct dependencies on `babel-core@6` and `babel-loader@7`.
+* If you aren't using Babel yourself, and don't have .babelrc, install following dependencies:
+  ```
+  npm i -D @babel/core babel-loader@next
+  ```
+* If you're using Babel 6, make sure that you have direct dependencies on `babel-core@6` and `babel-loader@7`.
 
 ### start-storybook opens browser automatically
 

addons/info/src/components/makeTableComponent.js

@@ -1,5 +1,4 @@
-/* eslint-disable no-underscore-dangle */
-
+/* eslint-disable no-underscore-dangle,react/forbid-foreign-prop-types */
 import PropTypes from 'prop-types';
 import React from 'react';
 

app/svelte/README.md

@@ -29,5 +29,5 @@ You can also build a [static version](https://storybook.js.org/basics/exporting-
 - [ ] Support Svelte markup directly in stories
 - [ ] Add Svelte storybook generator
 - [ ] Provide stories that show advanced Svelte use cases
- - [ ] Hydratable
- - [ ] Advanced mount options
+- [ ] Hydratable
+- [ ] Advanced mount options

docs/README.md

@@ -19,24 +19,24 @@ Documentation is written in Markdown and located inside the [`docs/src/pages`](h
 0. Explain **why** in addition to **how**. If something is designed a certain way for a reason, provide that reason.
 1. Provide examples of code snippets whenever possible - showing is always better than telling.
 2. Avoid simplifying problems - this frustrates users even more when they don't understand something "simple".
-  * Bad examples:
-    - `All you need to do is apply...`
-    - `Simply add...`
-    - `The object is just...`
+* Bad examples:
+  - `All you need to do is apply...`
+  - `Simply add...`
+  - `The object is just...`
 3. Use concise language - The less time users spend on reading and understanding docs, the better.
-  * Avoid using passive voice.
-    - Passive (bad): `It is believed by Storybook that empowering component builders is important.`
-    - Active (good): `Storybook believes in empowering component builders.`
-  * Place action in the verb.
-    - Indirect action (bad): `A refactor of this code is necessary`.
-    - Direct action (good): `This code needs to be refactored`.
+* Avoid using passive voice.
+  - Passive (bad): `It is believed by Storybook that empowering component builders is important.`
+  - Active (good): `Storybook believes in empowering component builders.`
+* Place action in the verb.
+  - Indirect action (bad): `A refactor of this code is necessary`.
+  - Direct action (good): `This code needs to be refactored`.
 4. Avoid the use of pronouns - documentation should not address the reader because not everything applies to the person reading our docs.
-  * Don't use `you` to refer to the user or third party.
-    - Pronoun (bad): `You can also...`
-    - Without pronoun (good): `Users can also...`
-  * Don't use `we` to refer to Storybook, contributors, or Storybook users.
-    - Pronoun (bad): `We can create this component...`
-    - Without pronoun (good): `The component can be created...`
-  * Don't use `he`, `she`, `him`, `her`, etc. to refer to third party unless referring to a specific person.
-  * Refer to contributors and the product as `Storybook`.
-  * Refer to users as `users`.
+* Don't use `you` to refer to the user or third party.
+  - Pronoun (bad): `You can also...`
+  - Without pronoun (good): `Users can also...`
+* Don't use `we` to refer to Storybook, contributors, or Storybook users.
+  - Pronoun (bad): `We can create this component...`
+  - Without pronoun (good): `The component can be created...`
+* Don't use `he`, `she`, `him`, `her`, etc. to refer to third party unless referring to a specific person.
+* Refer to contributors and the product as `Storybook`.
+* Refer to users as `users`.

docs/src/pages/basics/guide-svelte/index.md

@@ -16,7 +16,7 @@ The Webpack setup is very similar to [Svelte CLI's](https://github.com/sveltejs/
 In this guide, we are trying to set up Storybook for your Svelte project.
 
 > It is very important to remember that Svelte components are precompiled from
-.svelte or .html files to vanilla javascript, so there is no 'runtime'.
+> .svelte or .html files to vanilla javascript, so there is no 'runtime'.
 
 ## Table of contents
 
@@ -116,8 +116,8 @@ shorthand. It's the equivalent to `on:click="fire('click', event)"`, but it's
 worth knowing about especially in this "component wrapper" scenario.
 
 > If your component doesn't use slots, you don't need to do this, but if it does
-or some other svelte functionality that requires the component to exist in a svelte
-view, then this is how to do that.
+> or some other svelte functionality that requires the component to exist in a svelte
+> view, then this is how to do that.
 
 You would then write a story for this "view" the exact same way you did with a component.
 

examples/react-native-typescript/src/App.tsx

@@ -31,9 +31,7 @@ const styles = StyleSheet.create({
   },
 });
 
-interface Props {}
-
-export default class App extends React.Component<Props> {
+export default class App extends React.Component<{}> {
   render() {
     return (
       <View style={styles.container}>

lib/cli/generators/HTML/template/stories/index.stories.js

@@ -1,4 +1,4 @@
-import { document } from 'global';
+import { document, console } from 'global';
 import { storiesOf } from '@storybook/html';
 
 storiesOf('Demo', module)