Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom webpack config warnings #4009

Merged
merged 4 commits into from
Aug 15, 2018
Merged

Conversation

igor-dv
Copy link
Member

@igor-dv igor-dv commented Aug 12, 2018

Issue: Fix the #3981 + a bit more refactoring

What I did

I've refactored loadCustomWebpackConfig.js and now we have a serverRequire.js that will be able to load client's scripts based on their preferred compiler on server (Currently the only usecase is webpack.config, but I assume will be more, for example: presets, single config file, etc')

@igor-dv igor-dv self-assigned this Aug 12, 2018
@codecov
Copy link

codecov bot commented Aug 12, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@4121d26). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4009   +/-   ##
=========================================
  Coverage          ?   38.79%           
=========================================
  Files             ?      444           
  Lines             ?     5589           
  Branches          ?      751           
=========================================
  Hits              ?     2168           
  Misses            ?     3026           
  Partials          ?      395
Impacted Files Coverage Δ
lib/core/src/server/config/interpret-files.js 72.72% <0%> (ø)
lib/core/src/server/loadCustomWebpackConfig.js 0% <0%> (ø)
lib/core/src/server/serverRequire.js 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4121d26...746c2e2. Read the comment docs.

@igor-dv igor-dv merged commit 93745d7 into master Aug 15, 2018
@igor-dv igor-dv deleted the fix-custom-webpack-config-warnings branch August 15, 2018 12:52
@emmenko
Copy link

emmenko commented Aug 21, 2018

Any ETA on when this fix will be released? 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants