Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bogus warning: impossible to import loader for .js #3981

Closed
zsgalusz opened this issue Aug 8, 2018 · 2 comments
Closed

Bogus warning: impossible to import loader for .js #3981

zsgalusz opened this issue Aug 8, 2018 · 2 comments

Comments

@zsgalusz
Copy link

zsgalusz commented Aug 8, 2018

If you are reporting a bug or requesting support, start here:

Bug or support request summary

This may already be an older issue, but I just noticed it. When building storybook it shows a nonsensical warning:

info @storybook/react v4.0.0-alpha.16
info
info => Loading custom addons config.
WARN => Custom configuration file redacted/.storybook/webpack.config.js is detected
WARN    but impossible to import loader for .js
info => Loading custom webpack config (full-control mode).

From a quick investigation of the webpack config loader this is because interpret returns null for .js extensions (which is fine, since no loader is needed for them), which on the other hand storybook's webpack config loader misinterprets and warns that it can't load the loader (which it doesn't need). Regardless of the warning then it proceeds to require it so this is just a minor cosmetical issue.

Steps to reproduce

Build storybook with a custom webpack config in a js file. At the start of the build, it will show the above warning.

Please specify which version of Storybook and optionally any affected addons that you're running

  • @storybook/react v4.0.0-alpha.16

Affected platforms

  • I assume any, so long as a custom webpack.config.js file is present
@igor-dv
Copy link
Member

igor-dv commented Aug 8, 2018

Thanks, @zsgalusz, It's not an old issue. This ability was introduced a few alphas ago.

@Hypnosphi
Copy link
Member

Released as 4.0.0-alpha.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants