Server: Add json indexer #22460
Merged
Server: Add json indexer #22460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
added
bug
patch:yes
yannbf
reviewed
May 8, 2023
code/renderers/server/src/preset.ts
Outdated
| const meta: StaticMeta = { | ||
| title: json.title, | ||
| }; | ||
| const stories: IndexedStory[] = json.stories.map((story: any) => { |
There was a problem hiding this comment.
Is it possible to type story here?
Server: Add json indexer to preset Co-authored-by: Donnie Flood <[email protected]>
…okjs/storybook into shilman/20627-fix-server-indexer
This was referenced May 9, 2023
Merged
shilman
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20627
Telescopes off #22443
What I did
Heavily inspired by #22296
@storybook/server@yannbf I'll improve the CLI behavior in a follow-up PR
How to test