-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: implement JSON story file format as indexer #22296
Conversation
How to test is not about the unit-tests, it is how we can see your code working, like how did you see the result of your code ? |
Yeah fair point. I have a local story in json format which I put into a test. It passes obviously but not sure what the snapshot should actually be. For example, where do the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this @floodfx !! I'm on vacation for the next few days but will take a closer look next week & do my best to give guidance.
Hi @floodfx. I really like your intent, cause I have the same idea as basic with more capabilities like import-export stories, and generate default stories from a specific component library, it will be great, I can pair with you on this if you would like |
Yes sure @floodfx can you just add some test stories so I can start from there with you? |
I added dc5a9b8 which is generally the format we use. I think the problem I have is I don’t know the extent of what the json story format should support and where these json story attributes should end up in the output? |
thanks @shilman. lmk if I can be helpful. |
ok great! I am excited to try it out. thanks @shilman |
@floodfx, thank you so much for taking the time and effort into this pull request. We appreciate it 🙏 ! I want to follow up on one thing that was left out of this pull request. If you're ok with it, can you message me on our Discord Server (same username) so that we can go over it? Looking forward to hearing from you. Have a great day. Stay safe. |
Closes #20627
What I did
loadCsfFromJson
function inCsfFile.ts
.json
files inpreset.ts
using above.json
files incodegen-importfn-script.ts
How to test
Haven't added a test yet. Would like some feedback on above approach / code and answers to some of the TODOs particularly in
loadCsfFromJson
.Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]