-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vite: Add react docgen types #21338
Vite: Add react docgen types #21338
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @IanVS ! Was in the process of submitting my own PR for this but you beat me to it
/** | ||
* Configures `@joshwooding/vite-plugin-react-docgen-typescript` | ||
*/ | ||
reactDocgenTypescriptOptions: Parameters<typeof docgenTypescript>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be Parameters<typeof docgenTypescript>[0]
? I think parameters returns an array
Nice! |
@shilman Since you guys seem to work on this, updated the following ticket reproduction to #21399 [Bug]: No JSDoc generation when story outside root or symlinked (MonoRepo Blocker)
|
@D1no that seems unrelated to this PR. Maybe you're thinking of something else? |
@IanVS Maybe. The work on vite typescript docgen seems to be pretty fragmented. Have no insights 🤷🏻♂️ overview. If unrelated, ignore. |
Closes #20789
What I did
Adds types for react docgen options to the react-vite framework
How to test
Generate a sandbox for react-vite/default-ts, add an option in the main.ts like:
it should not error.
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]