Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: reactDocgen types missing from @storybook/react-vite #20789

Closed
yannbf opened this issue Jan 25, 2023 · 1 comment · Fixed by #21338
Closed

[Bug]: reactDocgen types missing from @storybook/react-vite #20789

yannbf opened this issue Jan 25, 2023 · 1 comment · Fixed by #21338

Comments

@yannbf
Copy link
Member

yannbf commented Jan 25, 2023

Describe the bug

@storybook/react-webpack5 has types for typescript.reactDocgen as can be seen here. Similar types (though options should probably come from @joshwooding/vite-plugin-react-docgen-typescript and not @storybook/react-docgen-typescript-plugin) should be provided for vite as well.

To Reproduce

This fails:

import { StorybookConfig } from '@storybook/react-vite'

const config: StorybookConfig = {
  typescript: {
    reactDocgen: 'none',
  },
}

export default config;

System

No response

Additional context

No response

@IanVS IanVS self-assigned this Jan 27, 2023
@shilman shilman moved this to Required for GA in Core Team Projects Mar 5, 2023
@github-project-automation github-project-automation bot moved this from Required for GA to Done in Core Team Projects Mar 6, 2023
@shilman
Copy link
Member

shilman commented Mar 6, 2023

Zoinks!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.0-beta.62 containing PR #21338 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb@next upgrade --prerelease

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants