Build: fix playwright unsynced version in CI #20778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…same version as the docker image
ndelangen
changed the title
yannbf
reviewed
Jan 25, 2023
ndelangen
commented
Jan 25, 2023
yannbf
reviewed
Jan 25, 2023
| packageJson.resolutions = { | ||
| ...storybookVersions, | ||
| 'enhanced-resolve': '~5.10.0', // TODO, remove this | ||
| playwright: '1.30.0', // this is for our CI test, ensure we use the same version as docker image, it should match version specified in `./code/package.json` and `.circleci/config.yml` |
There was a problem hiding this comment.
Oh, maybe we can even import package json version and use it here? so we don't have to maintain two places and once one is updated, this is also updated?
ndelangen
deleted the
norbert/ensure-playwright-version-sync-in-sandboxes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This will prevent future failures of our CI caused by mismatching version of playwright