Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: fix playwright unsynced version in CI #20778

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Build: fix playwright unsynced version in CI #20778

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab8c3a4
add a resolution for playwright to ensure that all sandboxes use the …
ndelangen Jan 25, 2023
d2938f9
Update scripts/utils/yarn.ts
ndelangen Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion scripts/utils/yarn.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,11 @@ export const addPackageResolutions = async ({ cwd, dryRun }: YarnOptions) => {

const packageJsonPath = path.join(cwd, 'package.json');
const packageJson = await readJSON(packageJsonPath);
packageJson.resolutions = { ...storybookVersions, 'enhanced-resolve': '~5.10.0' };
packageJson.resolutions = {
...storybookVersions,
'enhanced-resolve': '~5.10.0', // TODO, remove this
playwright: '1.30.0', // this is for our CI test, ensure we use the same version as docker image, it should match version specified in `./code/package.json` and `.circleci/config.yml`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, maybe we can even import package json version and use it here? so we don't have to maintain two places and once one is updated, this is also updated?

};
await writeJSON(packageJsonPath, packageJson, { spaces: 2 });
};

Expand Down