Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preact-Vite: Minor readme and dependency cleanups #20432

Merged
merged 2 commits into from
Dec 30, 2022
Merged

Preact-Vite: Minor readme and dependency cleanups #20432

merged 2 commits into from
Dec 30, 2022

Conversation

KrofDrakula
Copy link
Member

Issue: Address followup PR feedback from #20390

What I did

Implemented comments left on the PR after it was merged.

@KrofDrakula KrofDrakula changed the title Follow up 20390 Implement comments raised after #20390 Dec 29, 2022
@KrofDrakula KrofDrakula mentioned this pull request Dec 29, 2022
Merged
3 tasks
IanVS
IanVS approved these changes Dec 29, 2022
View reviewed changes
Copy link
Member

@IanVS IanVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for following up.

@KrofDrakula
Copy link
Member Author

@IanVS IanVS changed the title Implement comments raised after #20390 Preact-Vite: Minor readme and dependency cleanups Dec 30, 2022
@IanVS IanVS added dependencies and removed other labels Dec 30, 2022
@IanVS IanVS merged commit 1cf5f17 into next Dec 30, 2022
@IanVS IanVS deleted the follow-up-20390 branch December 30, 2022 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanVS IanVS IanVS approved these changes

Assignees
No one assigned
Labels
dependencies react
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KrofDrakula @IanVS