Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preact-Vite: Minor readme and dependency cleanups #20432

Merged
merged 2 commits into from
Dec 30, 2022
Merged

Preact-Vite: Minor readme and dependency cleanups #20432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f6b320
Address PR feedback from #20390
KrofDrakula Dec 29, 2022
7eb9a27
Update yarn.lock
KrofDrakula Dec 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions code/frameworks/preact-vite/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

### In a project without Storybook

Follow the prompts after running this command in your Next.js project's root directory:
Follow the prompts after running this command in your Preact project's root directory:

```bash
npx storybook@next init
Expand Down Expand Up @@ -40,8 +40,7 @@ Update your `main.js` to change the framework property:
module.exports = {
// ...
framework: {
// name: '@storybook/react-webpack5', // Remove this
name: '@storybook/preact-vite', // Add this
name: '@storybook/preact-vite', // <- Change this
options: {},
},
};
Expand Down
15 changes: 4 additions & 11 deletions code/frameworks/preact-vite/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,7 @@
"import": "./dist/preset.mjs",
"types": "./dist/preset.d.ts"
},
"./package.json": {
"require": "./package.json",
"import": "./package.json",
"types": "./package.json"
}
"./package.json": "./package.json"
},
"main": "dist/index.js",
"module": "dist/index.mjs",
Expand All @@ -51,12 +47,9 @@
"prep": "../../../scripts/prepare/bundle.ts"
},
"dependencies": {
"@preact/preset-vite": "^2.5.0",
"@rollup/pluginutils": "^4.2.0",
"@preact/preset-vite": "^2.0.0",
"@storybook/builder-vite": "7.0.0-beta.16",
"@storybook/preact": "7.0.0-beta.16",
"ast-types": "^0.14.2",
"magic-string": "^0.26.1"
"@storybook/preact": "7.0.0-beta.16"
},
"devDependencies": {
"@types/node": "^16.0.0",
Expand All @@ -68,7 +61,7 @@
"vite": "^3.0.0 || ^4.0.0"
},
"engines": {
"node": "^14.18 || >=16"
"node": ">=16"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion code/frameworks/react-vite/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
"vite": "^3.0.0 || ^4.0.0"
},
"engines": {
"node": "^14.18 || >=16"
"node": ">=16"
},
"publishConfig": {
"access": "public"
Expand Down
7 changes: 2 additions & 5 deletions code/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5193,7 +5193,7 @@ __metadata:
languageName: node
linkType: hard

"@preact/preset-vite@npm:^2.5.0":
"@preact/preset-vite@npm:^2.0.0":
version: 2.5.0
resolution: "@preact/preset-vite@npm:2.5.0"
dependencies:
Expand Down Expand Up @@ -6891,13 +6891,10 @@ __metadata:
version: 0.0.0-use.local
resolution: "@storybook/preact-vite@workspace:frameworks/preact-vite"
dependencies:
"@preact/preset-vite": ^2.5.0
"@rollup/pluginutils": ^4.2.0
"@preact/preset-vite": ^2.0.0
"@storybook/builder-vite": 7.0.0-beta.16
"@storybook/preact": 7.0.0-beta.16
"@types/node": ^16.0.0
ast-types: ^0.14.2
magic-string: ^0.26.1
typescript: ~4.9.3
vite: ^4.0.0
peerDependencies:
Expand Down