Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Add React peer dep runtime check #20206

Merged
merged 3 commits into from
Dec 13, 2022
Merged

CLI: Add React peer dep runtime check #20206

merged 3 commits into from
Dec 13, 2022

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Dec 12, 2022 •
edited by shilman
Loading

Issue: #20203

What I did

Adding a peer dep error when react and react-dom are not installed.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@valentinpalkovic valentinpalkovic added the build Internal-facing build tooling & test updates label Dec 12, 2022
@valentinpalkovic valentinpalkovic force-pushed the valentin/add-react-peer-dep-warning branch from c100c04 to 0eafd67 Compare December 13, 2022 08:13
@ndelangen ndelangen mentioned this pull request Dec 13, 2022
Closed
@shilman shilman changed the title Add React Peer dep warning CLI: Add React peer dep runtime check Dec 13, 2022
@shilman shilman added maintenance User-facing maintenance tasks and removed build Internal-facing build tooling & test updates labels Dec 13, 2022
shilman
shilman approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor punctuation issue

code/lib/cli/src/ensure-react-peer-deps.ts Outdated Show resolved Hide resolved
@shilman shilman added the cli label Dec 13, 2022
@valentinpalkovic valentinpalkovic merged commit a1fc7e3 into next Dec 13, 2022
@valentinpalkovic valentinpalkovic deleted the valentin/add-react-peer-dep-warning branch December 13, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees

@valentinpalkovic valentinpalkovic

Labels
cli maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valentinpalkovic @shilman