Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runtime check for react/react-dom peer dependencies & clear error message #20203

Closed
shilman opened this issue Dec 12, 2022 · 3 comments
Closed

Runtime check for react/react-dom peer dependencies & clear error message #20203

shilman opened this issue Dec 12, 2022 · 3 comments
Assignees
@valentinpalkovic
Labels
core maintenance User-facing maintenance tasks

Comments

@shilman
Copy link
Member

shilman commented Dec 12, 2022 •
edited
Loading

I talked to @jpzwarte and he does not have react/react-dom installed in his project.

I think this is going to be confusing to many people. We may want to consider adding a runtime check to confirm that react + react-dom are installed, and explain to the user why they are needed, and how they can remove docs if they do not want that feature.

Originally posted by @IanVS in #20160 (comment)
@shilman shilman added maintenance User-facing maintenance tasks core labels Dec 12, 2022
@shilman shilman moved this to Required for beta announcement in Core Team Projects Dec 12, 2022
@IanVS IanVS mentioned this issue Dec 12, 2022
Merged
3 tasks
@valentinpalkovic valentinpalkovic mentioned this issue Dec 13, 2022
Closed
@ndelangen
Copy link
Member

@valentinpalkovic Looks like this got also assigned to you?

Your PR: #20206 seems to fix this?

@valentinpalkovic
Copy link
Contributor

@ndelangen Exactly. The PR should fix this issue.

@shilman shilman added the linear label Dec 13, 2022
@shilman
Copy link
Member Author

shilman commented Dec 13, 2022

Yippee!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.0-beta.5 containing PR #20206 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Dec 13, 2022
Repository owner moved this from Required for beta announcement to Done in Core Team Projects Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinpalkovic valentinpalkovic

Labels
core maintenance User-facing maintenance tasks
Projects
Core Team Projects
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shilman @ndelangen @valentinpalkovic