Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset page between tests #47

Merged
merged 7 commits into from
Feb 23, 2022
Merged

fix: reset page between tests #47

merged 7 commits into from
Feb 23, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Feb 10, 2022

Attempts to fix #39

📦 Published PR as canary version: 0.0.3-canary.47.e38bd00.0

✨ Test out this PR locally via:

npm install @storybook/[email protected]
# or 
yarn add @storybook/[email protected]

Version

Published prerelease version: v0.0.3-next.10

Changelog

🐛 Bug Fix

Authors: 2

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does it work? Seems like tests are failing

[TEST]   ● Atoms/Button › WaitForElementToBeRemoved › play-test
[TEST] 
[TEST]     page.evaluate: ReferenceError: __test is not defined
[TEST] 
[TEST]       at eval (eval at evaluate (:3:2389), <anonymous>:4:15)
[TEST]       at t.default.evaluate (<anonymous>:3:2412)
[TEST]       at t.default.<anonymous> (<anonymous>:1:44)
[TEST]       at Object.<anonymous> (stories/atoms/Button.stories.js:173:35)

@shilman shilman added the bug Something isn't working label Feb 11, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor nits

src/csf/transformCsf.ts Outdated Show resolved Hide resolved
src/csf/transformCsf.ts Outdated Show resolved Hide resolved
@yannbf yannbf added the stress test Triggers stress tests label Feb 23, 2022
@yannbf yannbf merged commit 75acd03 into next Feb 23, 2022
@yannbf yannbf mentioned this pull request Feb 23, 2022
@yannbf yannbf deleted the fix/reset-page-between-tests branch August 23, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stress test Triggers stress tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] page.evaluate: Execution context was destroyed, most likely because of a navigation.
2 participants