-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING: Upgrade Jest to v29 #348
Conversation
Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: @jest/[email protected] |
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is new author?A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package. Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! cc @yannbf shall we release those PRs?
6cd615e
to
394a73b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #348 +/- ##
=======================================
Coverage 76.66% 76.66%
=======================================
Files 11 11
Lines 180 180
Branches 40 40
=======================================
Hits 138 138
Misses 42 42 ☔ View full report in Codecov by Sentry. |
@kasperpeulen @yannbf Thank you both for tending to these! Note on this one: As it is breaking (Jest v29 itself breaks Node.js v12), maybe you want to consider doing a maintenance release of current Also esp #349 |
I think in theory it should be possible to retain Node.js v12 compatibility - it woudl take some rework of the ci/tests though. |
Dropping node 12 is fine, storybook itself also doesn't support node 12 anymore. |
@kasperpeulen right, i was thinking for the benefit of downstreams as well as users who haven't upgraded yet, merging and releasing #349 first would be great. So my proposed order would be #349 -> release -> #354 -> #348 (this PR) WDYT? |
60c35a9
to
371dc84
Compare
Hey there! Sorry for not checking this sooner. I'll update this PR and test it out next week! |
🚀 PR was released in |
#319 + #345 but rebased on
next
.Blocked by
Version
Published prerelease version:
v0.14.0-next.2
Changelog
🚀 Enhancement
🐛 Bug Fix
engines.node
to>=12.0.0
#351 (@legobeat)🏠 Internal
yarn.lock
#347 (@legobeat)📝 Documentation
Authors: 4