-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document index.json mode for Svelte CSF #263
Conversation
Codecov ReportBase: 75.86% // Head: 75.86% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## next #263 +/- ##
=======================================
Coverage 75.86% 75.86%
=======================================
Files 11 11
Lines 174 174
Branches 36 36
=======================================
Hits 132 132
Misses 42 42 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JReinhold just needs a small tweak, and this should be good to go. Also, at some point in the future, we'll need to address the addon's documentation. But that's a whole different conversation that we can have later on.
Thanks for taking the time and effort to update the documentation. Appreciate it 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good. Thanks for taking care of the feedback so promptly. Appreciate it 🙏 ! Will merge this in a bit if you don't get around to it in the meantime @JReinhold
🚀 PR was released in |
This PR updates the Readme to also mention that
index.json
mode is useful for testing stories not written as plain CSF stories.This was prompted by #262.