Fix safe json stringify code #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansottowirtz
force-pushed
the
fix-safe-json-stringify
branch
from
0499a2b
to
eaaebc4
Compare
yannbf
approved these changes
Feb 1, 2023
There was a problem hiding this comment.
Hey @hansottowirtz thank you so so much for your contribution, and extra thanks for that wonderful reproduction you've given in the issue! Sorry I only had time to look into this today, but it's all great <3
yannbf
added
bug
Merged
This was referenced Mar 6, 2023
Merged
Merged
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces code from https://github.com/moll/json-stringify-safe with code from https://github.com/davidmarkclements/fast-safe-stringify. That library also has max depth and breadth options, so I added a maxDepth of 5 and maxEdges of 100.
Fixes #238.
Version
Published prerelease version:
v0.10.0-next.6Changelog
🚀 Enhancement
🐛 Bug Fix
📝 Documentation
Authors: 6