Fix StorybookTestRunnerError – length on undefined #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `yarn test-storybook` on my story, a 3rd party library throws an uncaught exception, but `StorybookTestRunnerError` _assumes_ `logs` is an array, which throws this error:
```console
UnhandledPromiseRejectionWarning: page.evaluate: TypeError: Cannot read properties of undefined (reading 'length')
at new StorybookTestRunnerError (<anonymous>:58:34)
at __throwError (<anonymous>:71:15)
at eval (eval at evaluate (:192:30), <anonymous>:4:19)
at UtilityScript.evaluate (<anonymous>:194:17)
at UtilityScript.<anonymous> (<anonymous>:1:44)
```
This PR simply **defaults `logs` to `[]`**, so I can correctly see that the underlying error is _actually_ coming from a 3rd party library:
```console
Cannot read properties of null (reading 'focus')
```
yannbf
approved these changes
Oct 7, 2022
Merged
|
🚀 PR was released in |
This was referenced Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
yarn test-storybookon my story, a 3rd party library throws an uncaught exception, butStorybookTestRunnerErrorassumeslogsis an array, which throws this error:This PR simply defaults
logsto[], so I can correctly see that the underlying error is actually coming from a 3rd party library:Cannot read properties of null (reading 'focus')Version
Published prerelease version:
v0.8.0-next.1Changelog
🚀 Enhancement
🐛 Bug Fix
Authors: 3