Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fixed missing peer dependency #184

Closed
wants to merge 1 commit into from

Conversation

bryanjtc
Copy link
Member

Fixes #183

@bryanjtc bryanjtc changed the title :fix Fixed missing peer dependency Fixed missing peer dependency Aug 27, 2022
@bryanjtc bryanjtc closed this Aug 27, 2022
@bryanjtc bryanjtc reopened this Aug 27, 2022
@p01
Copy link

p01 commented Sep 26, 2022

Interesting, I tried to use storybook/test-runner recently and had some missing peer dependency on:

"@babel/template": "^7.18.0",
"@babel/types": "^7.19.0",

Does that match your experience ?

@bryanjtc
Copy link
Member Author

bryanjtc commented Sep 26, 2022

Interesting, I tried to use storybook/test-runner recently and had some missing peer dependency on:

"@babel/template": "^7.18.0",
"@babel/types": "^7.19.0",

Does that match your experience ?

I had problems with babel when using the storybook configuration with typescript and I fixed adding some babel dependencies including @babel/types. I never had babel problems with the test-runner.

@bryanjtc bryanjtc changed the title Fixed missing peer dependency chore: Fixed missing peer dependency Oct 20, 2022
@shilman shilman closed this in #209 Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] @storybook/test-runner@npm:0.7.0 doesn't provide jest-environment-node
2 participants