Replace is-localhost-ip with can-bind-to-host #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can I get a review / merge? @yannbf |
|
Hey @knyzorg thank you so much for your contribution! I have extensively tested it and it seems like a great replacement. I will reach out in case there are any issues/uncovered scenarios in the future! 🚀 |
yannbf
approved these changes
Jul 18, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #122 by using a new package I wrote:
can-bind-to-hostIt is simpler in implementation, more reliable, and best of all - properly includes the MIT license!
Source: https://github.com/knyzorg/can-bind-to-host
Release Notes
Features
This release replaces an internal dependency
is-localhost-ipwithcan-bind-to-hostdue to a licensing issue incan-bind-to-host.Version
Published prerelease version:
v0.5.0-next.0Changelog
Release Notes
Replace is-localhost-ip with can-bind-to-host (#144)
Features
This release replaces an internal dependency
is-localhost-ipwithcan-bind-to-hostdue to a licensing issue incan-bind-to-host.🚀 Enhancement
Authors: 1