Skip to content

Commit

Permalink
Merge pull request #377 from storybookjs/next
Browse files Browse the repository at this point in the history
Release 0.14.0
  • Loading branch information
yannbf authored Nov 8, 2023
2 parents e8ba684 + 33f2385 commit 5ad71b4
Show file tree
Hide file tree
Showing 18 changed files with 15,691 additions and 11,710 deletions.
4 changes: 2 additions & 2 deletions .github/ISSUE_TEMPLATE/bug-report-🐞.md
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
---
name: "Bug report \U0001F41E"
about: Create a report to help us improve
title: "[bug] "
title: '[bug] '
labels: bug, needs triage
assignees: ''

---

**Describe the bug**
A clear and concise description of what the bug is.

**To Reproduce**
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
Expand Down
13 changes: 4 additions & 9 deletions .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,9 @@ jobs:
- name: Upgrade to storybook@next
run: |
npx storybook@next upgrade --prerelease --yes
env:
YARN_ENABLE_IMMUTABLE_INSTALLS: false

# TODO: This should not be necessary once @storybook/csf is properly updated
- name: Fix local @storybook/csf version
run: |
yarn add @storybook/[email protected]
- name: Run test runner
uses: mathiasvr/command-output@v1
id: tests
Expand Down Expand Up @@ -118,11 +116,8 @@ jobs:
- name: Upgrade to storybook@next
run: |
npx storybook@next upgrade --prerelease --yes
# TODO: This should not be necessary once @storybook/csf is properly updated
- name: Fix local @storybook/csf version
run: |
yarn add @storybook/[email protected]
env:
YARN_ENABLE_IMMUTABLE_INSTALLS: false

- name: Run test runner and expect failure
uses: mathiasvr/command-output@v1
Expand Down
10 changes: 9 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,12 @@ yarn-error.log
.nyc_output
coverage
test-results.json
**/junit.xml
**/junit.xml


/**/.yarn/*
!/**/.yarn/releases
!/**/.yarn/plugins
!/**/.yarn/sdks
!/**/.yarn/versions
/**/.pnp.*
6 changes: 5 additions & 1 deletion .storybook/main.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { StorybookConfig } from '@storybok/react-vite';

let stories = [
'../stories/docs/**/*.mdx',
// default title prefix
Expand Down Expand Up @@ -28,7 +30,7 @@ const addons = [
'@storybook/addon-interactions',
'@storybook/addon-coverage',
];
module.exports = {
const config: StorybookConfig = {
stories,
addons,
features: {
Expand All @@ -46,3 +48,5 @@ module.exports = {
autodocs: true,
},
};

export default config;
4 changes: 3 additions & 1 deletion .storybook/test-runner.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { toMatchImageSnapshot } from 'jest-image-snapshot';
import { getStoryContext } from '../dist/playwright/hooks';
import { getStoryContext, waitForPageReady } from '../dist/playwright/hooks';
import type { TestRunnerConfig } from '../dist';

const snapshotsDir = process.env.SNAPSHOTS_DIR || '__snapshots__';
Expand All @@ -22,6 +22,8 @@ const config: TestRunnerConfig = {
return;
}

await waitForPageReady(page);

// Visual snapshot tests
const image = await page.screenshot({ fullPage: true });
expect(image).toMatchImageSnapshot({
Expand Down
874 changes: 874 additions & 0 deletions .yarn/releases/yarn-3.6.3.cjs

Large diffs are not rendered by default.

5 changes: 5 additions & 0 deletions .yarnrc.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
enableTelemetry: 0

nodeLinker: node-modules

yarnPath: .yarn/releases/yarn-3.6.3.cjs
Loading

0 comments on commit 5ad71b4

Please sign in to comment.