Handle DOM Events #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cture is hiding its properties
Dom Event (and all it sub classes) is built in a way it's internal properties are accessible when querying them directly but "hidden" when iterating its keys.
With a code example it means: `Object.keys(new Event('click')) = ["isTrusted"]`
So to be able to stringify/parse more than just `isTrusted` info we need to create a new object and set the properties by hand. As there is no way to iterate the properties we rely on a list of hardcoded properties.
…their own folders
|
~Sadly it is not fixing the issue with Addon Actions, I think it's because telejson run both in Browser and Node (and Event aren't handled on Node side). To investigate... It looks like Edit: And no it wasn't that, it was just that the Event was nested in another object, see 177b649 |
gaetanmaisse
force-pushed
the
fix-event-serialization
branch
from
868284c to
46c1cb8
Compare
gaetanmaisse
force-pushed
the
fix-event-serialization
branch
from
46c1cb8 to
177b649
Compare
|
And finally, it's working 🎉
|
ndelangen
approved these changes
May 10, 2021
|
Released in 5.2.0 |
gaetanmaisse
added a commit
to storybookjs/storybook
that referenced
this pull request
May 10, 2021
A workaround has been found in `telejson` to keep interesting data when serializing DOM Event/CustomEvent. For details, see storybookjs/telejson#63
This was referenced May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dom Event (and all its subclasses) is built in a way its internal properties are accessible when querying them directly but "hidden" when iterating its keys.
With a code example it means:
Object.keys(new Event('click')) = ["isTrusted"]So to be able to stringify/parse more than just
isTrustedinfo we need to create a new object and set the properties by hand. As there is no way to iterate the properties we rely on a list of hardcoded properties.--
I also had to split the test suite to be able to have node and browser specific tests. We now have the following structure:
And the related NPM scripts:
--
Related to storybookjs/storybook#8544