Core: Add skip dispose option to ClientApi

[Gongreg]

Issue: storybookjs/react-native#11

What I did

Added an option to skip dispose call inside storiesOf.add() .

Relevant PR:

storybookjs/react-native#30

How to test

Added tests.

[shilman]

cc @tmeasday

[tmeasday]

@Gongreg I wonder if the option could be called something a bit clearer, maybe noStoryModuleHotDispose? Also perhaps we could put a comment in around the option explaining the rationale as we are sure to forget why it is there

[tmeasday]

Suggested change

	it('should not bind dispose inside add when disableAddStoryDispose is true', () => {
	it('should not call `module.hot.dispose` inside add when disableAddStoryDispose is true', () => {

[Gongreg]

@Gongreg I wonder if the option could be called something a bit clearer, maybe noStoryModuleHotDispose? Also perhaps we could put a comment in around the option explaining the rationale as we are sure to forget why it is there

I am having trouble with thinking of the name. This is not fully disabling hot story dispose. This is disabling one of the two dispose calls.

It is more of noStoryModuleAddMethodHotDispose :D

[tmeasday]

I guess what I was thinking is we are keeping the dispose for the kind (in .storiesOf) but not for the story (in .add) -- is that right?

[Gongreg]

That’s correct.

[tmeasday]

Haha, WFM.

[dannyhw]

Sorry to leave comments on old PR's but these changes are part of the fast refresh fix for react native storybookjs/react-native#30 any chance we could see this in another 5.3.x patch?