Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting in addon-info #980

Merged
merged 2 commits into from
May 9, 2017
Merged

Fix linting in addon-info #980

merged 2 commits into from
May 9, 2017

Conversation

usulpro
Copy link
Member

@usulpro usulpro commented Apr 30, 2017

No description provided.

@codecov
Copy link

codecov bot commented Apr 30, 2017

Codecov Report

Merging #980 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #980      +/-   ##
==========================================
+ Coverage    12.6%   12.61%   +<.01%     
==========================================
  Files         192      192              
  Lines        4426     4424       -2     
  Branches      707      707              
==========================================
  Hits          558      558              
+ Misses       3243     3241       -2     
  Partials      625      625
Impacted Files Coverage Δ
packages/addon-info/src/components/Node.js 0% <0%> (ø) ⬆️
packages/addon-info/src/components/PropTable.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e9fe66...695926e. Read the comment docs.

@theinterned
Copy link
Member

theinterned commented May 2, 2017

Nice one @usulpro I'm also working on fixing linting, and luckily hadn't done this package yet.

PR: #911

@theinterned theinterned mentioned this pull request May 2, 2017
14 tasks
@ndelangen
Copy link
Member

Can we do this all in 1 PR?
Which ones can we close?

@theinterned
Copy link
Member

@ndelangen if this is merged now as-is it shouldn't cause problems with PR #1000. In fact I haven't rebased in a while so if this is merged now I can deal with this change along with any others when I do rebase.

@theinterned
Copy link
Member

strangely, the fixes done in this PR are not things I was seeing reported when runnig the linting on the whole project.

@ndelangen
Copy link
Member

Sure if that's easier, I can merge this.

@ndelangen ndelangen merged commit 119d634 into storybookjs:master May 9, 2017
@shilman shilman added misc cleanup Minor cleanup style change that won't show up in release changelog and removed misc labels May 27, 2017
Copy link

nx-cloud bot commented Apr 2, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 695926e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants