-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix linting in addon-info #980
Conversation
Codecov Report
@@ Coverage Diff @@
## master #980 +/- ##
==========================================
+ Coverage 12.6% 12.61% +<.01%
==========================================
Files 192 192
Lines 4426 4424 -2
Branches 707 707
==========================================
Hits 558 558
+ Misses 3243 3241 -2
Partials 625 625
Continue to review full report at Codecov.
|
Can we do this all in 1 PR? |
@ndelangen if this is merged now as-is it shouldn't cause problems with PR #1000. In fact I haven't rebased in a while so if this is merged now I can deal with this change along with any others when I do rebase. |
strangely, the fixes done in this PR are not things I was seeing reported when runnig the linting on the whole project. |
Sure if that's easier, I can merge this. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 695926e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
No description provided.