Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Change main.js to main.ts to show it's possible #9775

Merged
merged 2 commits into from
Feb 8, 2020

Conversation

igor-dv
Copy link
Member

@igor-dv igor-dv commented Feb 6, 2020

Issue: #9765
Hi all =)

The issue claims it's not possible to use main.ts inside .storybook dir while it's actually possible since it's required with serverRequire.

What I did

renamed main.js to main.ts in cra-ts-kitchen-sink and changed a bit tsconfig.
tsignore there is because of the "isolatedModules": true, attribute that prevents using
commonjs.

TBD: gonna add this to docs soon.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2020

Fails
🚫

PR is not labeled with one of: ["cleanup","doc-dependencies:update","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS against 64dc292

@shilman shilman added maintenance User-facing maintenance tasks and removed documentation labels Feb 8, 2020
@shilman shilman changed the title Change main.js to main.ts to show it's possible Examples: Change main.js to main.ts to show it's possible Feb 8, 2020
@shilman shilman merged commit a16ed42 into next Feb 8, 2020
@shilman shilman deleted the 9765-main-ts-explain branch February 8, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants