Server: Initial support for @storybook/server #9722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Template based server side rendering Added a bunch of stories to the example app
* More snapshot tests * Fixed some bugs * Added kitchen sink example to demo app
…ybook into jonspalmer-storybook_server
tmeasday
changed the title
|
Oop, actually I can push to your branch, closing this. |
the mdx.tsx stuff really has nothing to do with this PR. That was @shilman piggy backing on the PR. I'd leave it to him to comment. |
|
The |
I guess the comment implies as "neither did the story" (which is true, the story didn't change if force render is true) that the behaviour is intended. Let's leave it for now. |
|
Going to merge from this branch |
shilman
changed the title
This was referenced Feb 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't commit to #9250 so this is a follow up PR to try and get it over the line
@jonspalmer there are still two unresolved comments on that PR that we need to sort out:
Is this a mistake or did I misunderstand: Initial support for @storybook/server #9250 (comment)
Do we need to deal with this TODO: https://github.com/storybookjs/storybook/pull/9250/files/be4d06c0cd69b2ed4a79ad390852770bfd6ccfeb#diff-83aae226cfb73b52d12dfd37ae15a411?
Also a change to
mdx.tsxgot dropped becausegenerateHrefWithHashdoesn't exist any more. I'm not sure if that's going to be a problem but I'll have a proper play with this once the above two questions are resolved.