Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: webpack config when excute 'yarn workspace vue-example dev' #9704

Merged
merged 1 commit into from
Mar 16, 2020
Merged

fix: webpack config when excute 'yarn workspace vue-example dev' #9704

merged 1 commit into from
Mar 16, 2020

Conversation

Seunghyum
Copy link
Contributor

Issue: when excute
yarn workspace vue-example dev
there are css and image loader bug in webpack

What I did

I add css-loader and fix file-loader to url-loader in wepback.config.js
and also add css-loader npm package to package.json

How to test

no need to test or update document. just
yarn workspace vue-example dev

@Seunghyum
fix: webpack config when excute 'yarn workspace vue-example dev'
7685636 
when excute 'yarn workspace vue-example dev', there are css and image loader bug in webpack
@stale
Copy link

stale bot commented Feb 23, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Feb 23, 2020
@shilman shilman added vue maintenance User-facing maintenance tasks labels Feb 23, 2020
@stale stale bot removed the inactive label Feb 23, 2020
@stale
Copy link

stale bot commented Mar 15, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Mar 15, 2020
@stale stale bot removed the inactive label Mar 15, 2020
@ndelangen ndelangen merged commit 7335d31 into storybookjs:next Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@alexandrebodin alexandrebodin Awaiting requested review from alexandrebodin

@igor-dv igor-dv Awaiting requested review from igor-dv

Assignees
No one assigned
Labels
maintenance User-facing maintenance tasks vue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Seunghyum @ndelangen @shilman