Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(addon-docs): ColorPalette style #9643

Merged
merged 3 commits into from
Jan 27, 2020
Merged

fix(addon-docs): ColorPalette style #9643

merged 3 commits into from
Jan 27, 2020

Conversation

frassinier
Copy link
Contributor

@frassinier frassinier commented Jan 27, 2020 •
edited
Loading

Issue:
ColorPalette style is not convenient when design tokens are there.

What I did

@domyen asked for some style changes in #9453 after it was merged, so here is another PR to fix them.

How to test

See demo

@vercel
Copy link

vercel bot commented Jan 27, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

@frassinier frassinier requested a review from domyen January 27, 2020 14:57
@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2020 •
edited
Loading

Fails
🚫

PR is not labeled with one of: ["cleanup","doc-dependencies:update","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS against e5229cd

@ndelangen ndelangen added bug patch:yes Bugfix & documentation PR that need to be picked to main branch and removed other labels Jan 27, 2020
@ndelangen ndelangen added this to the 5.3.x milestone Jan 27, 2020
@ndelangen ndelangen merged commit d401a25 into next Jan 27, 2020
@ndelangen ndelangen deleted the feat/addon-docs/colorpalette_style branch January 27, 2020 18:31
@shilman shilman modified the milestones: 5.3.x, 6.0.0 Jan 28, 2020
@shilman shilman removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jan 28, 2020
This was referenced Feb 24, 2020
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@tmeasday tmeasday Awaiting requested review from tmeasday

@domyen domyen Awaiting requested review from domyen

Assignees

@frassinier frassinier

Labels
addon: docs bug
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@frassinier @ndelangen @shilman