Source-loader: Bypass if file has no exports #9505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/7dqknwiqp |
shilman
reviewed
Jan 17, 2020
| @@ -15,7 +24,8 @@ export function transform(inputSource) { | |||
| localDependencies, | |||
| idsToFrameworks, | |||
| }) => { | |||
| const preamble = ` | |||
| const preamble = prefix | |||
There was a problem hiding this comment.
what's the concept of prefix? can you make a short comment above this line?
There was a problem hiding this comment.
Its not specific to prefix, just to signify the source loader is not parsing this file. Also prevents an rte since prefix was being used without a check below
shilman
changed the title
This was referenced Jan 17, 2020
This was referenced Feb 12, 2020
This was referenced Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #9457 #9412
What I did
source-loader does not handle named exports that are separate from the story definitions.
This PR bypasses the source-loader when it is unable to parse a file, so the stories will appear in the sidebar. However the source code will not available to see in docs mode.
How to test
added a story
Core/Re-export source loaderto demonstrate the issueconst Story1 = () => 'story1';
const Story2 = () => 'story2';
export { Story1, Story2 };