CLI: Fix sb init to use spawn.sync if creating package.json
#9359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atanasster
requested review from
ndelangen,
shilman and
stijnkoopal
as code owners
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/1u5j8ewwh |
ndelangen
approved these changes
Jan 8, 2020
|
it turns out the newly created package.json was never re-read after a yarn/npm init spawn. |
shilman
changed the title
sb init to use spawn.sync if creating package.json
This was referenced Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #9358
What I did
Not familiar with it, but seems the cross-spawn has changed?
I moved to use the sync method and also there were multiple unneeded parameters being returned
How to test
like in the issue,
sb init --type htmlor other storybook types