Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Inline rendering for web-components as default #8705

Merged
merged 1 commit into from
Nov 5, 2019

Conversation

daKmoR
Copy link
Contributor

@daKmoR daKmoR commented Nov 5, 2019

Issue:

What I did

  • Allow rendering web-components inline in docs mode.
  • Enable it by default

How to test

Open docs mode page on kitchen sink for web components.

I am not really a react pro so I am not sure if that is the best way to do it... but it works really nice and seems quite simple. 🤗

feedback welcome 🙏

@vercel
Copy link

vercel bot commented Nov 5, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/p36x9s9nk
🌍 Preview: https://monorepo-git-feat-docs-inline-web-components.storybook.now.sh

@shilman shilman changed the title feat(docs): support inline rendering for wc and enable by default Addon-docs: Inline rendering for web-components, by default Nov 5, 2019
@shilman shilman changed the title Addon-docs: Inline rendering for web-components, by default Addon-docs: Inline rendering for web-components as default Nov 5, 2019
@shilman shilman added this to the 5.3.0 milestone Nov 5, 2019
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bravo 🔥

@shilman shilman merged commit 15d4f13 into next Nov 5, 2019
@shilman shilman deleted the feat/docs-inline-web-components branch November 5, 2019 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants