Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React-Native: Add safe area wrapper for iphone x and later #8679

Merged
merged 4 commits into from
Nov 3, 2019

Conversation

Gongreg
Copy link
Member

@Gongreg Gongreg commented Nov 2, 2019

Issue: N/A.

Currently the top of addons panel is cut off when running on iphone x.

What I did

Added safe area view wrapper.

@Gongreg Gongreg added bug maintenance User-facing maintenance tasks react-native labels Nov 2, 2019
@Gongreg Gongreg requested review from shilman and ndelangen November 2, 2019 18:53
@vercel
Copy link

vercel bot commented Nov 2, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/7wrnymckm
🌍 Preview: https://monorepo-git-safe-area-view-fix.storybook.now.sh

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2019

Fails
🚫

Please choose only one of these labels: ["bug","maintenance"]

Generated by 🚫 dangerJS against 94f3441

@Gongreg Gongreg removed the maintenance User-facing maintenance tasks label Nov 2, 2019
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman changed the title Added safe area wrapper for iphone x and later. React-Native: Add safe area wrapper for iphone x and later Nov 3, 2019
@shilman shilman merged commit 9c87afb into next Nov 3, 2019
@shilman shilman deleted the safe-area-view-fix branch November 3, 2019 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants