Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Angular docs readme #8674

Merged
merged 4 commits into from
Nov 2, 2019
Merged

Addon-docs: Angular docs readme #8674

merged 4 commits into from
Nov 2, 2019

Conversation

shilman
Copy link
Member

@shilman shilman commented Nov 2, 2019

Issue: #6664

Add documentation. Minor bugfix.

@vercel
Copy link

vercel bot commented Nov 2, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/gqyx7kusu
🌍 Preview: https://monorepo-git-6664-angular-docs-readme.storybook.now.sh

@vercel vercel bot temporarily deployed to staging November 2, 2019 08:23 Inactive
@shilman
Copy link
Member Author

shilman commented Nov 2, 2019

Self-merging

@shilman shilman merged commit be3add9 into next Nov 2, 2019
@shilman shilman deleted the 6664-angular-docs-readme branch November 2, 2019 08:52
Copy link
Member

@kroeder kroeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


When you [install docs](#installation) you should get basic [DocsPage](../docs/docspage.md) documentation automagically for all your Angular stories, available in the `Docs` tab of the Storybook UI.

Pops tables for your components requires a few more steps. Docs for Angular relies on [Compodoc](https://compodoc.app/), the excellent API documentation tool. It supports `inputs`, `outputs`, `properties`, `methods`, `view/content child/children` as first class prop types.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a list of supported types? I would expect to get all these from an API doc tool without reading this.

We can leave it as is. I just think it's another place we need to maintain if we add missing types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants