Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-docs: Fix story scroll-to heuristics #8629

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Addon-docs: Fix story scroll-to heuristics #8629

merged 1 commit into from
Oct 30, 2019

Conversation

daKmoR
Copy link
Contributor

@daKmoR daKmoR commented Oct 29, 2019 •
edited by shilman
Loading

Issue: #8286

What I did

In Docs mode:

  • When selecting a story in the left menu scrolling was always starting from top.
  • Now it goes from story to story.
  • First story get's scrolled to "end" to show intro above.
  • Otherwise, scroll to "start".

How to test

Open web components kitchen sink and click on multiple stories in docs mode

Preview

left old - right new

Kapture 2019-10-29 at 23 48 05

@vercel
Copy link

vercel bot commented Oct 29, 2019 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/2693dpw9q
🌍 Preview: https://monorepo-git-fix-docs-mode-scrolling.storybook.now.sh

@shilman shilman changed the title fix(docs): scroll from story to story not always from top Addon-docs: Fix scroll from story to story not always from top Oct 29, 2019
@shilman shilman changed the title Addon-docs: Fix scroll from story to story not always from top Addon-docs: Fix scroll-to-story heuristics Oct 29, 2019
@shilman shilman changed the title Addon-docs: Fix scroll-to-story heuristics Addon-docs: Fix story scroll-to heuristics Oct 29, 2019
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Oct 29, 2019
@shilman shilman modified the milestones: 5.3.0, 5.2.x Oct 29, 2019
shilman
shilman approved these changes Oct 30, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent fix!!!! 👏👏👏

@shilman shilman merged commit 536a0bd into next Oct 30, 2019
@shilman shilman deleted the fix-docs-mode-scrolling branch October 30, 2019 08:21
@shilman shilman mentioned this pull request Oct 30, 2019
Closed
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Nov 9, 2019
shilman added a commit that referenced this pull request Nov 9, 2019
@shilman
Addon-docs: Fix story scroll-to heuristics (#8629)
629119c 
Addon-docs: Fix story scroll-to heuristics
This was referenced Nov 18, 2019
Merged
Merged
Merged
Merged
Merged
This was referenced Nov 30, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@alterx alterx Awaiting requested review from alterx

@igor-dv igor-dv Awaiting requested review from igor-dv

@tmeasday tmeasday Awaiting requested review from tmeasday

Assignees
No one assigned
Labels
addon: docs bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
5.2.x
Development

Successfully merging this pull request may close these issues.
2 participants
@daKmoR @shilman