Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Vue slots/events props table + generalization #8489

Merged
merged 12 commits into from
Oct 24, 2019

Conversation

shilman
Copy link
Member

@shilman shilman commented Oct 20, 2019

Issue: #8123

What I did

  • Props: Added sections prop for Vue/Angular etc (events/slots/etc.)
  • Left rows still back-compat for React (no sections needed)
  • Split react/vue props extraction & made it preset-configurable
  • Left props extract inference for React/Vue for back-compat
  • Cleaned up examples from Addon-docs: Fix React.forwardedRef/memo props #8445
  • Cleaned up DocgenButton from official-storybook as named export

What I need

  • Review Vue example ported from vue-addon-info - do we need more? @Aaron-Pool
  • PropsTable styling @domyen

How to test

React:

cd examples/official-storybook
yarn storybook

Vue:

cd ../vue-kitchen-sink
yarn storybook

@vercel
Copy link

vercel bot commented Oct 20, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/rg7c0d945
🌍 Preview: https://monorepo-git-8123-generalized-props-table.storybook.now.sh

@shilman shilman changed the title Addon-docs: generalized props table Addon-docs: Generalized props table Oct 20, 2019
@shilman shilman changed the title Addon-docs: Generalized props table Addon-docs: Generalized props table / Vue slots/events/etc Oct 20, 2019
@shilman shilman changed the title Addon-docs: Generalized props table / Vue slots/events/etc Addon-docs: Vue slots/events props table + generalization Oct 20, 2019
@Aaron-Pool
Copy link
Contributor

@shilman how would you like me to contribute examples? Actually pull this branch down, or just send you some code snippets directly?

@Aaron-Pool
Copy link
Contributor

Aaron-Pool commented Oct 22, 2019

@shilman I switched the callback-props being used in the vue stories to use vue events, and properly notated them for the docgen-api, like we discussed earlier today 👍 I also removed those few remaining static heights being set on a few of the inline stories, which was causing overflow issues. This is starting to look pretty great, appreciate the hard work! 🔥🔥🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants