CLI: Fix variable collisions in storiesof-to-csf #8106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hypnosphi
requested review from
aaronmcadam,
ndelangen,
shilman and
stijnkoopal
as code owners
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fix-storiesof-to-csf.storybook.now.sh |
|
Automention: Hey @Keraito, you've been tagged! Can you give a hand here? |
Preserve original name in case of collision
shilman
approved these changes
Sep 23, 2019
shilman
changed the title
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Oct 7, 2019
CLI: Fix variable collisions in storiesof-to-csf
This was referenced Oct 17, 2019
Merged
Merged
Merged
[Snyk] Upgrade @storybook/addon-actions from 5.2.1 to 5.2.3
GrabarzUndPartner/gp-vue-boilerplate#271
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
– Apply
storyNameFromKeybefore deciding whether to add an explicit name #8101– Prepend
_if story name starts with a digit– Check all the variable names (not only exports) when detecting collision. Preserve original name in case of collision