Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-knobs: Handle undefined array value #8006

Merged
merged 1 commit into from
Sep 26, 2019
Merged

Addon-knobs: Handle undefined array value #8006

merged 1 commit into from
Sep 26, 2019

Conversation

christophe-g
Copy link
Contributor

Fix #8005

@vercel
Copy link

vercel bot commented Sep 5, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@stale
Copy link

stale bot commented Sep 26, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Sep 26, 2019
shilman
shilman approved these changes Sep 26, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stale stale bot removed the inactive label Sep 26, 2019
@shilman shilman added this to the 5.2.x milestone Sep 26, 2019
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Sep 26, 2019
@shilman shilman changed the title make sure element does not fail when knob.value is undefined Addon-knobs: Handle undefined knob.value Sep 26, 2019
@shilman shilman changed the title Addon-knobs: Handle undefined knob.value Addon-knobs: Handle undefined array value Sep 26, 2019
@shilman shilman merged commit 38e018d into storybookjs:next Sep 26, 2019
@shilman shilman mentioned this pull request Sep 27, 2019
Closed
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Oct 7, 2019
shilman added a commit that referenced this pull request Oct 7, 2019
@shilman
Merge pull request #8006 from christophe-g/8005-liElement-array-prope…
eeeab8d 
…rty-breaks-storybook-knobs-when-when-value-is-undefined

Addon-knobs: Handle undefined array value
This was referenced Oct 17, 2019
Merged
Merged
Merged
Merged
Merged
Merged
@zachhardesty7 zachhardesty7 mentioned this pull request Jan 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@alexandrebodin alexandrebodin Awaiting requested review from alexandrebodin

@alterx alterx Awaiting requested review from alterx

@leonrodenburg leonrodenburg Awaiting requested review from leonrodenburg

@theinterned theinterned Awaiting requested review from theinterned

Assignees
No one assigned
Labels
addon: knobs bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
5.2.x
Development

Successfully merging this pull request may close these issues.

liElement Array property breaks storybook knobs when when value is undefined
2 participants
@christophe-g @shilman