-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Remove babel-register in favor of esm #7823
Conversation
This pull request is automatically deployed with Now. |
@Hypnosphi Could you submit your review for this possibly as soon as is convenient for you? We'd like to get this merged asap. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
What is the lowest Node version that our CLI officially supports? |
Before the change, it was 8: https://github.com/storybookjs/storybook/blob/next/lib/cli/.babelrc#L5 Maybe we should just transpile this package, as we do with other ones? |
@Hypnosphi |
dfdbd0d
to
8fde590
Compare
@shilman but our own sources can use some newer features |
@Hypnosphi We currently don't AFAIK, I'm ok with someone changing it over to transpile everything instead. |
@Hypnosphi open to doing that in a subsequent PR but want to get this out to address a core-js related issue in the CLI |
Some additional context wouldn't hurt our future selves |
Issue: having babel-register to transpile our CLI code when starting is bad
What I did
I migrated it to use
-r esm
instead