Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update angular example to v8 #7747

Merged
merged 13 commits into from
Sep 28, 2019
Merged

Update angular example to v8 #7747

merged 13 commits into from
Sep 28, 2019

Conversation

kroeder
Copy link
Member

@kroeder kroeder commented Aug 12, 2019

Issue:

What I did

Updating our angular example to the latest version

@kroeder kroeder requested review from alterx and igor-dv as code owners August 12, 2019 21:25
@vercel
Copy link

vercel bot commented Aug 12, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-update-angular-example-to-v8.storybook.now.sh

@kroeder kroeder mentioned this pull request Aug 16, 2019
Closed
@stale stale bot added the inactive label Sep 2, 2019
@kroeder
Copy link
Member Author

kroeder commented Sep 5, 2019

Can't proceed with this before we don't upgrade to node 10 in our CI
Angular 8 requires >= node 10

@stale stale bot removed the inactive label Sep 5, 2019
@kroeder kroeder added maintenance User-facing maintenance tasks angular labels Sep 5, 2019
@stale stale bot added the inactive label Sep 26, 2019
@kroeder
Copy link
Member Author

kroeder commented Sep 26, 2019

Waiting for #8173

@stale stale bot removed the inactive label Sep 26, 2019
@ndelangen ndelangen mentioned this pull request Sep 26, 2019
Merged
@storybookjs storybookjs deleted a comment from stale bot Sep 26, 2019
@storybookjs storybookjs deleted a comment from stale bot Sep 26, 2019
@ndelangen ndelangen added this to the 5.3.0 milestone Sep 26, 2019
@ndelangen ndelangen self-requested a review September 26, 2019 10:23
@ndelangen
Merge branch 'tech/run-node10-in-ci' into update-angular-example-to-v8
1e4200b 
# Conflicts:
#	examples/angular-cli/angular.json
#	examples/angular-cli/package.json
#	yarn.lock
@ndelangen
Copy link
Member

@kroeder Hope this helps 🙏

@kroeder kroeder mentioned this pull request Sep 28, 2019
Closed
@vercel vercel bot temporarily deployed to staging September 28, 2019 11:31 Inactive
@vercel vercel bot temporarily deployed to staging September 28, 2019 11:35 Inactive
shilman
shilman approved these changes Sep 28, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@shilman shilman merged commit 2ebcb6c into next Sep 28, 2019
@shilman shilman deleted the update-angular-example-to-v8 branch September 28, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@alterx alterx Awaiting requested review from alterx

@igor-dv igor-dv Awaiting requested review from igor-dv

@ndelangen ndelangen Awaiting requested review from ndelangen

@thomasbertet thomasbertet Awaiting requested review from thomasbertet

Assignees

@kroeder kroeder

Labels
angular maintenance User-facing maintenance tasks
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kroeder @ndelangen @shilman