Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-centered: Ability to disable for specific story #7709

Merged
merged 3 commits into from
Aug 8, 2019
Merged

Addon-centered: Ability to disable for specific story #7709

merged 3 commits into from
Aug 8, 2019

Conversation

MarioCadenas
Copy link
Contributor

@MarioCadenas MarioCadenas commented Aug 7, 2019 •
edited
Loading

addon-centered

What I did

I used the makeDecorator function to wrap centered function, so you can disable addon centered by passing disable parameter in the storie.

parameters: {
  centered: { 
    disable: true 
  }
}

How to test

You can see it working in the examples/official-storybook storybook.

@vercel
Copy link

vercel bot commented Aug 7, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fork-mariocadenas-feature-addon-cente-cedc71.storybook.now.sh

@MarioCadenas
Copy link
Contributor Author

I'm adding this to support everything and not only react =)

@MarioCadenas MarioCadenas changed the title ability to disable addon-centered in specific storie Addon-centered: ability to disable addon-centered in specific storie Aug 7, 2019
@MarioCadenas MarioCadenas changed the title Addon-centered: ability to disable addon-centered in specific storie Addon-centered: ability to disable addon-centered in specific story Aug 7, 2019
@shilman
Copy link
Member

shilman commented Aug 8, 2019

Awesome @MarioCadenas 🎖

shilman
shilman approved these changes Aug 8, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & tested!

@shilman shilman changed the title Addon-centered: ability to disable addon-centered in specific story Addon-centered: Add parameter to disable for specific story Aug 8, 2019
@shilman shilman changed the title Addon-centered: Add parameter to disable for specific story Addon-centered: Ability to disable for specific story Aug 8, 2019
@shilman shilman merged commit 15483c5 into storybookjs:next Aug 8, 2019
@davidcmoulton davidcmoulton mentioned this pull request Nov 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@danielduan danielduan Awaiting requested review from danielduan

@kazupon kazupon Awaiting requested review from kazupon

@usulpro usulpro Awaiting requested review from usulpro

Assignees
No one assigned
Labels
addon: centered feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarioCadenas @shilman