Fix select knob default selection with array #7568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliotlarson
requested review from
alexandrebodin,
alterx,
leonrodenburg and
theinterned
as code owners
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fork-elliotlarson-next.storybook.now.sh |
When using a select knob with arrays as option values, the selected key for the default value was not getting set properly. The code was comparing two arrays with ===, which is always false. This stringifies the arrays and then does the comparison.
kroeder
approved these changes
Jul 26, 2019
There was a problem hiding this comment.
I found a good place for a test 🙂
Although, I'm not sure I test this correctly 🤔
Even though the component itself has the correct value does this ensure that it is actually selected?
@ndelangen can you help me out here? I don't know much about enzyme nor react components
PR LGTM
|
@kroeder Thank you for adding a spec! I usually put my specs side by side with the implementation files. Somehow I totally missed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #7569
What I did
When using a select knob with arrays as option values, the default value was not getting set properly on the select list. The code was comparing two arrays with ===, which is always false.
I updated the code to stringify the arrays for doing the comparison.
How to test
There was not an existing test for the select knob that I could augment/add onto for this edge case. However, this is a pretty small update. I did try it out locally and it worked (manual test).