Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: update sb init to module format for Angular #7502

Merged
merged 1 commit into from
Jul 23, 2019
Merged

CLI: update sb init to module format for Angular #7502

merged 1 commit into from
Jul 23, 2019

Conversation

shilman
Copy link
Member

@shilman shilman commented Jul 20, 2019 •
edited
Loading

Issue: #7499

Module format docs: #7498

@vercel
Copy link

vercel bot commented Jul 20, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-7499-module-format-angular.storybook.now.sh

tmeasday
tmeasday approved these changes Jul 23, 2019
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndelangen ndelangen merged commit 68f06ff into next Jul 23, 2019
@ndelangen ndelangen deleted the 7499-module-format-angular branch July 23, 2019 08:15
@ndelangen ndelangen added this to the 5.2.0 milestone Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

@ndelangen ndelangen Awaiting requested review from ndelangen

@stijnkoopal stijnkoopal Awaiting requested review from stijnkoopal

@CodeByAlex CodeByAlex Awaiting requested review from CodeByAlex

@kroeder kroeder Awaiting requested review from kroeder

@igor-dv igor-dv Awaiting requested review from igor-dv

@amcdnl amcdnl Awaiting requested review from amcdnl

Assignees
No one assigned
Labels
angular cli feature request
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@shilman @tmeasday @ndelangen