Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React native: Emit event when story is rendered #7449

Merged
merged 1 commit into from
Jul 18, 2019
Merged

React native: Emit event when story is rendered #7449

merged 1 commit into from
Jul 18, 2019

Conversation

Gongreg
Copy link
Member

@Gongreg Gongreg commented Jul 17, 2019

Issue: N/A

I would like to get an event to know when the story has finished rendering.

What I did

Added event when story is rendered

@vercel
Copy link

vercel bot commented Jul 17, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-story-rendered.storybook.now.sh

@shilman shilman changed the title Emit event when story is rendered in react native React native: Emit event when story is rendered Jul 18, 2019
@shilman shilman added this to the 5.2.0 milestone Jul 18, 2019
shilman
shilman approved these changes Jul 18, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman merged commit 97b07f9 into next Jul 18, 2019
@shilman shilman deleted the story-rendered branch July 18, 2019 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@danielduan danielduan Awaiting requested review from danielduan

@rmevans9 rmevans9 Awaiting requested review from rmevans9

@tmeasday tmeasday Awaiting requested review from tmeasday

Assignees
No one assigned
Labels
feature request react-native
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Gongreg @shilman