Addon-viewports: Add back default viewports #7448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wports larger then main area ADD migration guide to get old defaults again
ndelangen
requested review from
danielduan,
saponifi3d and
usulpro
as code owners
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fix-viewport.storybook.now.sh |
shilman
requested changes
Jul 17, 2019
There was a problem hiding this comment.
@ndelangen Why does this need to be a breaking change? Let's not remove withViewport until 6.0? And what's the problem with just using INITIAL_VIEWPORTS?
|
withViewport is already not exported... Might have happened in the TS migration? |
wuweiweiwu
reviewed
Aug 2, 2019
| @@ -195,12 +196,15 @@ export const ViewportTool: FunctionComponent<{}> = React.memo( | |||
| }, | |||
| [`#${wrapperId}`]: { | |||
| padding: theme.layoutMargin, | |||
| display: 'flex', | |||
| alignContent: 'center', | |||
| alignItems: 'center', | |||
| justifyContent: 'center', | |||
There was a problem hiding this comment.
if its not a flex container do we still need justify content and align items?
shilman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did