Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use same param key as backgrounds addon #7437

Merged
merged 2 commits into from
Jul 16, 2019
Merged

use same param key as backgrounds addon #7437

merged 2 commits into from
Jul 16, 2019

Conversation

RWOverdijk
Copy link
Member

Issue: #7432

What I did

Fixed the thing.

  1. The constant's value did not match with the one in addon-backgrounds.
  2. When loading this addon first, state is null. For some reason. Now, the addon works again when loaded first.

How to test

Run an app with the addon and see it work. Before this fix (on latest beta at least) the addon didn't run at all.

@RWOverdijk RWOverdijk added the bug label Jul 16, 2019
@vercel
Copy link

vercel bot commented Jul 16, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fix-ondevicebackgrounds.storybook.now.sh

@ndelangen ndelangen merged commit 65b608c into next Jul 16, 2019
@ndelangen ndelangen deleted the fix/ondevice/backgrounds branch July 16, 2019 13:33
@ndelangen ndelangen added this to the 5.2.0 milestone Jul 16, 2019
@RWOverdijk RWOverdijk mentioned this pull request Jul 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@RWOverdijk @ndelangen